Metadata #149
Merged
Metadata #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +52,7 @@ def get_filenames(paths) | |||
| end | |||
|
|
|||
| HANDLERS = [ | |||
| ChefAuditDir, ServerspecDir, FlatDir | |||
| ProfileDir, ServerspecDir, FlatDir | |||
There was a problem hiding this comment.
Is there renaming typo? ProfileDir vs ChefAuditDir
There was a problem hiding this comment.
Great catch, I missed to add ChefAuditDir! Thank you @chris-rock
|
This PR has passed 'Verify' and is ready for review and approval! |
| @@ -15,16 +15,17 @@ def resolve(target) | |||
| # find all files in the folder | |||
| files = Dir[File.join(target, '**', '*')] | |||
| # remove the prefix | |||
| files = files.map { |x| x[target.length + 1..-1] } | |||
| files = files.map { |x| x.sub(target, '') } | |||
There was a problem hiding this comment.
way better. Thanks @arlimus
|
Thanks @arlimus for this improvement. |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Oct 26, 2015
Merged change 1d1b403b-c61e-4a7d-8445-b90a20e9e464 From review branch metadata into master Signed-off-by: chartmann <chartmann@chef.io>
|
Change: 1d1b403b-c61e-4a7d-8445-b90a20e9e464 approved by: @chris-rock |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-include libraries is about providing library functions to all tests within scope:
Here, crypto_lib will be included by default, sothat crypto_test can use it.