create inspec.io/tutorial.html #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
reviewed
Feb 14, 2017
| @@ -44,6 +44,7 @@ | |||
| task :assemble do | |||
| Log.section 'Copy only tutorial into middleman build directory' | |||
| sh('rsync -a --exclude=index.html www/tutorial/dist/* www/build/') | |||
| sh('cp www/tutorial/dist/index.html www/build/tutorial.html') | |||
There was a problem hiding this comment.
Do we need the other files as well? https://github.com/chef/inspec/blob/master/tasks/www.rb#L26-L29
There was a problem hiding this comment.
Yes :) see line 46 there, it will sync all the others, excluding index.html because it exists already. This MR just adds back the index.html and renames it to tutorial.html
There was a problem hiding this comment.
Perfect, thank you for the explanation.
chris-rock
approved these changes
Feb 14, 2017
adamleff
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1485
Signed-off-by: Dominik Richter dominik.richter@gmail.com