Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Habitat profile artifact creator #1505

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Feb 23, 2017

Adding a Habitat profile artifact creator

Two new commands have been created:

  • inspec habitat profile create /path/to/profile
  • inspec habitat profile upload /path/to/profile

The create command creates a Habitat artifact that contains the contents
of the Habitat profile found at the provided path. This will be used later
in some Habitat + InSpec integrations.

The upload command does the same create process but then uploads the
resulting artifact to the Habitat Depot.

Signed-off-by: Adam Leff adam@leff.co

@adamleff adamleff force-pushed the adamleff/add-habitat-archiver branch 2 times, most recently from b02ac68 to 1348533 Compare February 23, 2017 03:58
@adamleff adamleff requested review from chris-rock and arlimus and removed request for chris-rock and arlimus February 23, 2017 04:23
@adamleff
Copy link
Contributor Author

After talking to @chris-rock, I'm going to move this out to an inspec-habitat bundle to keep the CLI UX consistent.

@adamleff adamleff force-pushed the adamleff/add-habitat-archiver branch from 1348533 to 702acff Compare February 23, 2017 21:11
@adamleff adamleff changed the title Adding a Habitat profile archiver Adding a Habitat profile artifact creator Feb 23, 2017
@adamleff
Copy link
Contributor Author

@chris-rock ready for another review whenever you have a moment :)

@adamleff adamleff force-pushed the adamleff/add-habitat-archiver branch from 702acff to 9fb0e8d Compare February 23, 2017 23:07
Two new commands have been created:

 * inspec habitat profile create /path/to/profile
 * inspec habitat profile upload /path/to/profile

The `create` command creates a Habitat artifact that contains the contents
of the Habitat profile found at the provided path. This will be used later
in some Habitat + InSpec integrations.

The `upload` command does the same create process but then uploads the
resulting artifact to the Habitat Depot.

Signed-off-by: Adam Leff <adam@leff.co>
@adamleff adamleff force-pushed the adamleff/add-habitat-archiver branch from 9fb0e8d to 0342cca Compare February 23, 2017 23:26
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, works like a charm. Lets add the usage documentation in another iteration.

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge awesome work, love it!! Thank you so much for turning this around so quickly Adam 😁

@arlimus arlimus merged commit 6511a67 into master Feb 24, 2017
@arlimus arlimus deleted the adamleff/add-habitat-archiver branch February 24, 2017 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants