Fix formatting and colors on Windows #1510
Conversation
Fixes issue #1508 * Windows terminals don't support extended ANSI colours. Use basic + intensity * Windows terminals don't support UTF-8 well so don't use special characters Other OS'es get what they had before. Signed-off-by: Richard Nixon <richard.nixon@btinternet.com>
There was a problem hiding this comment.
Great finding @trickyearlobe Thank you for raising the issue and proposing a fix.
| 'small' => ' ', | ||
| }.freeze | ||
| case RUBY_PLATFORM | ||
| when /windows|mswin|msys|mingw|cygwin/ |
There was a problem hiding this comment.
We should find a solution that is not dependent on OS detection, since there are terminal available for windows that support UTF8 like http://cmder.net/
I am okay to merge it anyway since this is solving the problem for most Windows users.
There was a problem hiding this comment.
My customer prefers to use Powershell. CMDER does support UTF8 but the symbols don't render and it still has the extended colors problem. The symbols may just be down to selected font or codepage (have to execute chcp 65001 to get UTF8 on most machines)
There was a problem hiding this comment.
BTW... I love CMDER... its my go-to terminal when I have to use Windows :)
There was a problem hiding this comment.
Thank you @trickyearlobe for the explanation.
There was a problem hiding this comment.
Doing a bit more digging, it seems that for the UTF8 symbols to display, you need to switch to UTF8 with chcp 65001 and then change the terminal font to one that includes emojis (such as Segoe UI Symbol).
I also did a bit of digging around autodetection of terminal type or color support. ANSI does define some queries but most of the Windows terminals ignore them (despite the sequences being documented on MSDN)
See this link https://en.wikipedia.org/wiki/Emoji#Microsoft_Windows
There was a problem hiding this comment.
@trickyearlobe Thank you for the deeper investigation. I agree with you that the os detection is a safe bet.
Fixes issue #1508
Other OS'es get what they had before.
Signed-off-by: Richard Nixon richard.nixon@btinternet.com