Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready for review - inspec.io bug fixes, #1440, #1420, #1465, #1421, #1437,#1226, #1494, #1495 #1512

Merged
merged 2 commits into from
Mar 5, 2017
Merged

Ready for review - inspec.io bug fixes, #1440, #1420, #1465, #1421, #1437,#1226, #1494, #1495 #1512

merged 2 commits into from
Mar 5, 2017

Conversation

hannah-radish
Copy link
Contributor

@hannah-radish hannah-radish commented Feb 24, 2017 •
edited
Loading

  • Added banner for webinars (present and future)
  • Added CSS support for IE10, IE11, Edge
  • Fixed the nasty website crash on resized Edge
  • Added better rendering for mobile nav, fixed issue with alignment during resize
  • Fixed URL bug for demos links
  • Added redirect from inspec.io/downloads to downloads.chef.io
  • Validated gordon_config URL fix
  • Sidebar fixes, highlighted when on content
  • Muli font for air-gapped environments with helvetica, san-serif fallback
  • Other smaller changes..

@hannah-radish hannah-radish self-assigned this Feb 24, 2017
@hannah-radish hannah-radish changed the title WIP - DO NOT MERGE WIP - DO NOT MERGE, #1440, #1420, #1465 Feb 24, 2017
@hannah-radish hannah-radish changed the title WIP - DO NOT MERGE, #1440, #1420, #1465 WIP - DO NOT MERGE, #1440, #1420, #1465, #1421, #1226, #1494, #1495 Feb 24, 2017
This was referenced Feb 24, 2017
Closed
Closed
@hannah-radish hannah-radish changed the title WIP - DO NOT MERGE, #1440, #1420, #1465, #1421, #1226, #1494, #1495 WIP -Inspec.io Bug Fixes DO NOT MERGE, #1440, #1420, #1465, #1421, #1226, #1494, #1495 Feb 24, 2017
@hannah-radish hannah-radish mentioned this pull request Feb 24, 2017
Closed
@hannah-radish hannah-radish changed the title WIP -Inspec.io Bug Fixes DO NOT MERGE, #1440, #1420, #1465, #1421, #1226, #1494, #1495 WIP -Inspec.io Bug Fixes DO NOT MERGE, #1440, #1420, #1465, #1421, #1437,#1226, #1494, #1495 Feb 24, 2017
@chris-rock
Copy link
Contributor

fixes #1440
fixes #1420
fixes #1465
fixes #1421
fixes #1437
fixes #1226
fixes #1494
fixes #1495

@hannah-radish hannah-radish mentioned this pull request Feb 24, 2017
Closed
@hannah-radish hannah-radish changed the title WIP -Inspec.io Bug Fixes DO NOT MERGE, #1440, #1420, #1465, #1421, #1437,#1226, #1494, #1495 Ready for review - inspec.io bug fixes, #1440, #1420, #1465, #1421, #1437,#1226, #1494, #1495 Feb 25, 2017
@adamleff adamleff self-requested a review March 3, 2017 15:43
adamleff
adamleff suggested changes Mar 3, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not frontend-smart enough to thoroughly review the CSS changes, but I did test things locally and they looked fine.

I'd like to see URLs be relative (so no hard-coding of http://inspec.io) if at all possible to make testing locally and in acceptance environments easier/possible.

Other than that, just some small changes that we should address before releasing.

www/source/docs/index.html.slim Outdated
p Complete a short interactive demo
a.btn.try-demo href="#" Try the Demo
p.txt-margin Complete a short interactive demo
a.btn.try-demo href="http://inspec.io/tutorial" Try the Demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a relative URL (i.e. href="/tutorial") so it works in local/acceptance environments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like one absolute-to-relative URL change missed.

www/source/downloads.html.slim Outdated

javascript:

location.replace("http://downloads.chef.io");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be http://downloads.chef.io/inspec?

www/source/index.html.slim Outdated

p.t-white
| Upcoming Webinar: Testing at the Edges
a href="https://events.chef.io/events/testing-at-the-edges/" View the Event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this event on March 1 and has come-and-gone... we probably need to put a new event here or perhaps put the surprise code example back.

www/source/index.html.slim Outdated
@@ -141,7 +134,7 @@ header.blue-gradient.margin-top-offset
br/
span.code-attribute end

a.btn.strict-right.t-white.try-demo.mobile-hide Try the Demo
a.btn.strict-right.t-white.try-demo.mobile-hide href="http://inspec.io/tutorial" Try the Demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above - can we make this a relative URL instead of a direct URL?

www/source/index.html.slim Outdated
@@ -213,6 +206,6 @@ header.blue-gradient.margin-top-offset
| { should be_listening }
br/
span.code-attribute end
a.btn.strict-right.t-white.try-demo.mobile-hide Try the Demo
a.btn.strict-right.t-white.try-demo.mobile-hide href="http://inspec.io/tutorial" Try the Demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment re: relative URL.

www/source/layouts/_footer.slim Outdated

.row.margin-top-xs
a.btn.t-white.try-demo.hide-for-small-only href="#" Try the Demo
a.btn.t-white.try-demo.hide-for-small-only href="http://inspec.io/tutorial" Try the Demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment re: relative URL.

www/source/layouts/_nav.slim Outdated
a.btn.try-demo href="#" Try the Demo
li.main-nav--link.hide-docs
li.main-nav--link.nav-cta.hide-for-small-only
a.btn.try-demo href="http://inspec.io/tutorial" Try the Demo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment re: relative URL.

@adamleff
Copy link
Contributor

adamleff commented Mar 3, 2017

@hannah-radish looks like one URL change still needed, but otherwise looks good. I'm happy to approve once we get the DCO bot happy. Let me know if you need help with that.

Bug fixes for Inspec.io
23434f3 
- Added banner for webinars (present and future)
- CSS support for IE10, IE11, Edge
- Fixed URL bug for demo
- Fixed Edge browser resize bug
- Changes to relative path, update event info

Signed-off-by: Hannah Maddy <hmaddy@chef.io>
Updated Tutorial URL in Docs
74a2a37 
Signed-off-by: Hannah Maddy <hmaddy@chef.io>
@hannah-radish
Copy link
Contributor Author

@adamleff okay, fixed the docs link for demo and DCO.

@adamleff
Copy link
Contributor

adamleff commented Mar 5, 2017

Looks great, @hannah-radish - I'm merging now, feel free to push live whenever you're ready, or let me know if you need me to do it.

@adamleff adamleff merged commit 66dce38 into master Mar 5, 2017
@chris-rock chris-rock deleted the HM-BugFixesWeb-022317 branch March 6, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleff adamleff adamleff approved these changes

Assignees

@hannah-radish hannah-radish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hannah-radish @chris-rock @adamleff