Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows_task docs: Correct syntax error and misspelled word #1525

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

spiffytech
Copy link

No description provided.

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiffytech Thank you for spotting this. Once you signed-off the commit, LGTM
see https://github.com/chef/inspec/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

@adamleff
Copy link
Contributor

adamleff commented Mar 1, 2017

Great find and fix, @spiffytech! This is mergeable as soon as the DCO bot is happy.

Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending DCO acceptance.

@chris-rock
Copy link
Contributor

chris-rock commented Mar 2, 2017

@spiffytech Please just run:

git checkout spiffytech:patch-1
git commit --amend -s
git push origin spiffytech:patch-1 -f

Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the DCO does not apply to the chef-web-docs repo, and this is only a documentation update, I am going to accept this PR as-is. I will also be putting forth a Chef RFC/procedure change exempting in-repo docs-only changes (such as what we do in the chef/inspec repo) from DCO requirements.

@adamleff adamleff merged commit 7667c9c into inspec:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants