Avoid connection timeout of "inspec version" #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Makoto Nozaki <makoto.nozaki@twosigma.com>
|
Note: The next line, |
adamleff
suggested changes
Mar 5, 2017
There was a problem hiding this comment.
@makotots thank you so much for this PR! I agree that keeping the definition of the options at the same level for consistency is the right thing to do. Would you mind pushing up a new commit with that change? Then I'll be happy to get this approved.
lib/utils/latest_version.rb
Outdated
| @@ -8,7 +8,8 @@ class LatestInSpecVersion | |||
| # fetches the latest version from rubygems server | |||
| def latest | |||
| uri = URI('https://rubygems.org/api/v1/gems/inspec.json') | |||
| res = Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') {|http| | |||
| res = Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https', | |||
| open_timeout: 0.5) {|http| | |||
| http.read_timeout = 0.5 | |||
There was a problem hiding this comment.
I agree with your comment that this should be moved up to the #start opts for consistency. Thank you for suggesting it!
Signed-off-by: Makoto Nozaki <makoto.nozaki@twosigma.com>
adamleff
approved these changes
Mar 6, 2017
|
Great work, @makotots! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1537
Signed-off-by: Makoto Nozaki makoto.nozaki@twosigma.com