Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving the nokogiri reference into the gemspec file #1576

Merged
merged 2 commits into from
Mar 20, 2017
Merged

moving the nokogiri reference into the gemspec file #1576

merged 2 commits into from
Mar 20, 2017

Conversation

jkerry
Copy link
Contributor

@jkerry jkerry commented Mar 20, 2017 •
edited
Loading

fixes #1562 by moving the nokogiri reference to the gemspec file instead of the gem file. also removes the stale dependency on the rspec junit formatter.

John Kerry added 2 commits March 19, 2017 21:56
moving the nokogiri reference into the gemspec file
dd9ec61 
Signed-off-by: John Kerry <john@kerryhouse.net>
removing an unnecessary require of the rspec junit formatter
d4a0ae4 
Signed-off-by: John Kerry <john@kerryhouse.net>
@jkerry jkerry closed this Mar 20, 2017
@jkerry jkerry reopened this Mar 20, 2017
@jkerry jkerry closed this Mar 20, 2017
@jkerry jkerry reopened this Mar 20, 2017
adamleff
adamleff approved these changes Mar 20, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jkerry! This looks good and tests good locally as well.

chris-rock
chris-rock approved these changes Mar 20, 2017
View reviewed changes
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jkerry

@chris-rock chris-rock merged commit c11e4d2 into inspec:master Mar 20, 2017
@jkerry jkerry deleted the fixing_nokogiri branch March 20, 2017 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-rock chris-rock chris-rock approved these changes

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot load such file -- nokogiri
3 participants
@jkerry @chris-rock @adamleff