Move simulator gems to www #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simulator gems are not necessary for building InSpec, only the website. This is currently causing issues in the Jenkins infrastructure due to a downstream dependency of github-markup. Signed-off-by: Adam Leff <adam@leff.co>
adamleff
force-pushed
the
adamleff/move-simulator-to-www-gemfile
branch
from
8c7fc64
to
199cb16
Compare
chris-rock
reviewed
Mar 21, 2017
| @@ -19,3 +19,9 @@ gem 'middleman-livereload' | |||
| gem 'middleman-autoprefixer' | |||
| gem 'middleman-syntax' | |||
| gem 'redcarpet' | |||
|
|
|||
| group :simulator do | |||
There was a problem hiding this comment.
Lets not forget to update the rakefile and tasks to reflect that change
adamleff
added a commit
that referenced
this pull request
Mar 22, 2017
This is a follow-up to #1585. The website-related Rake tasks have been moved to a www-specific Rakefile which can be found in the www/ directory. Any web-release-related gems have been moved to the www Gemfile as well. This also included modifying the docs rake tasks to be path- independent as they currently expect that Rake is being run from the root of the repo. Signed-off-by: Adam Leff <adam@leff.co>
adamleff
added a commit
that referenced
this pull request
Mar 22, 2017
This is a follow-up to #1585. The website-related Rake tasks have been moved to a www-specific Rakefile which can be found in the www/ directory. Any web-release-related gems have been moved to the www Gemfile as well. This also included modifying the docs rake tasks to be path- independent as they currently expect that Rake is being run from the root of the repo. Signed-off-by: Adam Leff <adam@leff.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simulator gems are not necessary for building InSpec, only the website.
This is currently causing issues in the Jenkins infrastructure due to
a downstream dependency of github-markup.
Signed-off-by: Adam Leff adam@leff.co