add tag object #1590
Merged
add tag object #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
suggested changes
Mar 22, 2017
| @value = value | ||
| end | ||
|
|
||
| def to_hash |
There was a problem hiding this comment.
I don't see @name and @opts used here. Should this be @key and @value?
There was a problem hiding this comment.
That is fixed now :-) I also added a test for to_hash
lib/inspec/objects/tag.rb
Outdated
| end | ||
|
|
||
| def to_s | ||
| "Tag #{@key} with #{@value}" |
There was a problem hiding this comment.
Just a Ruby styling thing, but I try to avoid using instance variables if they're set up as attr_readers or attr_accessors, just for consistency.
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/tag
branch
from
71bfc5b
to
8798d0f
Compare
adamleff
approved these changes
Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tag support to InSpec objects.