Feature/fix ability to pass in supermarket url #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like this was originally supposed to work, but at some point
the default value was put in the method body rather than in the method
parameters.
This change allows you to configure the supermarket_url in test kitchen
like so:
```
verifier:
inspec_tests:
- name: linux-hardening
supermarket: som3guy/apache-disa-stig
supermarket_url: https://my.supermarket.com
```
Signed-off-by: Ryan Larson <ryan.mango.larson@gmail.com>
Signed-off-by: Ryan Larson <ryan.mango.larson@gmail.com>
Signed-off-by: Ryan Larson <ryan.mango.larson@gmail.com>
chris-rock
approved these changes
Mar 25, 2017
There was a problem hiding this comment.
Thank you @rylarson for finding and fixing that annoying bug
adamleff
suggested changes
Mar 28, 2017
There was a problem hiding this comment.
@rylarson thanks for the fix! Can you please add addressable to the gemspec for this change? Right now, we're bringing in addressable via other dependencies. Since we're now depending on it directly, we should declare that for future-proofing purposes.
Signed-off-by: Ryan Larson <ryan.mango.larson@gmail.com>
rylarson
force-pushed
the
feature/fixAbilityToPassInSupermarketUrl
branch
from
18cd76e
to
170808b
Compare
|
@adamleff The gemspec has been updated with addressable. Sorry for missing that. |
|
No apologies necessary, @rylarson! I'll review this shortly. |
adamleff
approved these changes
Mar 29, 2017
|
@rylarson this looks fantastic, and major props for adding tests for the We greatly appreciate your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable customization of supermarket_url
It looks like this was originally supposed to work, but at some point
the default value was put in the method body rather than in the method
parameters.
This change allows you to configure the supermarket_url in test kitchen
like so:
I added tests for all of the methods on
Supermarket::APIto make sure we don't have any regressions going forward.