Require Ruby 2.1 #1599
Merged
Require Ruby 2.1 #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSpec now depends on nokogiri which has a dependency of Ruby 2.1 or later. If someone tries to `gem install inspec` using Ruby 2.0, it will fail on the nokogiri dependency rather than InSpec itself. Additionally, Ruby 2.0 is already EOL. Signed-off-by: Adam Leff <adam@leff.co>
|
Makes a lot of sense and also it's good to finally have it inside of gemspec. Thank you for this 👍 |
arlimus
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InSpec now depends on nokogiri which has a dependency of Ruby 2.1 or
later. If someone tries to
gem install inspecusing Ruby 2.0, itwill fail on the nokogiri dependency rather than InSpec itself.
Additionally, Ruby 2.0 is already EOL.
Fixes #1597