Fix port resource for invalid IP address in netstat output #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is the more root cause of the issue here that netstat is outputting a fixed-width field that it has to truncate long ipv6 addresses, and either you need to go digging for an option to make it output the full field, or else should really hit the /proc filesystem directly to pull out information? |
|
@lamont-granquist yeah, I really want to rewrite this resource because of the issues you mentioned. I was unable to get it to display the full address, but I at least wanted to unblock you and any others running into this issue. |
Netstat will sometimes output an IPv6 address that is not formatted correctly; the address is either truncated or uses or implies the `::` shorthand notation twice. This yields an invalid IPv6 address and causes IPAddr.new to choke. This change guards against invalid IP addresses and ensures they do not end up in the port resource's entries list. Signed-off-by: Adam Leff <adam@leff.co>
arlimus
force-pushed
the
adamleff/bad-ipv6-address
branch
from
aad5e1d
to
8e693a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netstat will sometimes output an IPv6 address that is not
formatted correctly; the address is either truncated or uses
or implies the
::shorthand notation twice. This yields aninvalid IPv6 address and causes IPAddr.new to choke.
This change guards against invalid IP addresses and ensures they
do not end up in the port resource's entries list.
Fixes #1602