Don't resolve send calls with dot-notation
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #its has its(pun) own way of handling calls with a dot-notation, the full call is never passed to the resource. For example:
```ruby
describe json('file') do
its('a.b.c') { should eq 123 }
end
```
This is resolved to calling `json('file').a.b.c` and thus doesnt work as an intended `json('file').send('a.b.c'). For now use
regular its-behavior of calling `json('file').params ... its(%w{a b c}) { should ... }`.
Its' behavior must be improved.
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Oct 27, 2015
Merged change 68a5ab3f-f9c5-482c-a61e-2d5776f8931f From review branch json into master Signed-off-by: chartmann <chartmann@chef.io>
|
Change: 68a5ab3f-f9c5-482c-a61e-2d5776f8931f approved by: @chris-rock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extend json+yaml+csv tests.