Fix and document registry issues #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
…handled Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/fix-regedit-ps
branch
from
1b53a31
to
266241f
Compare
adamleff
suggested changes
Apr 7, 2017
lib/resources/registry_key.rb
Outdated
| @@ -66,7 +66,10 @@ def initialize(name, reg_key = nil) | |||
| # generate registry_key if we do not have a regular expression | |||
| @options[:path] = @options[:hive] | |||
| # add optional key path | |||
| @options[:path] += '\\' + @options[:key] if @options[:key] | |||
| if @options[:key] | |||
There was a problem hiding this comment.
Can we break out the building of the path to a private helper method in this class and add some tests to it? There's enough conditional logic in building the path now that I think it's warranted.
There was a problem hiding this comment.
I agree with you @adamleff This would increase the quality!
Broke out some of the conditional logic in the `#initialize` method into helper methods and added tests. Signed-off-by: Adam Leff <adam@leff.co>
|
Thank you @adamleff for improving my PR. |
adamleff
approved these changes
Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powershell 3 has issues with some characters in strings when used in combination with
ConvertTo-Json:By using
ConvertTo-Json -Compress, it just works:registry_keybehavior (Unable to get .NET Version) #1131registry_key#1268