Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add draft version of InSpec DSL topic #165

Merged
merged 2 commits into from
Nov 1, 2015
Merged

add draft version of InSpec DSL topic #165

merged 2 commits into from
Nov 1, 2015

Conversation

jamescott
Copy link

No description provided.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@chris-rock
Copy link
Contributor

@jamescott please update the intro with the latest developments

@chris-rock chris-rock force-pushed the jscott/addinspecdsldraftcopy12345 branch from 1e15735 to d1179e7 Compare October 30, 2015 11:45
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@chris-rock chris-rock force-pushed the jscott/addinspecdsldraftcopy12345 branch from d1179e7 to bf16594 Compare October 30, 2015 14:22
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@chris-rock chris-rock force-pushed the jscott/addinspecdsldraftcopy12345 branch 2 times, most recently from 8f29614 to 4b469a1 Compare October 31, 2015 10:47
@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@arlimus arlimus force-pushed the jscott/addinspecdsldraftcopy12345 branch from 4b469a1 to 2a400c3 Compare November 1, 2015 21:58
@arlimus
Copy link
Contributor

arlimus commented Nov 1, 2015

Thank you both!! 👍 Great intro
@delivery approve

@chef-delivery
Copy link
Contributor

Failed to approve change: 55adeaee-3f30-4331-9716-77bf57bbe464
Change must pass verify before approving. @arlimus

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@arlimus
Copy link
Contributor

arlimus commented Nov 1, 2015

@delivery approve again ;)

chef-delivery added a commit that referenced this pull request Nov 1, 2015
@chef-delivery
Merge pull request #165 from chef/jscott/addinspecdsldraftcopy12345
70008d4 
Merged change 55adeaee-3f30-4331-9716-77bf57bbe464

From review branch jscott/addinspecdsldraftcopy12345 into master

Signed-off-by: drichter <drichter@chef.io>
@chef-delivery chef-delivery merged commit 70008d4 into master Nov 1, 2015
@chef-delivery chef-delivery deleted the jscott/addinspecdsldraftcopy12345 branch November 1, 2015 22:06
@chef-delivery
Copy link
Contributor

Change: 55adeaee-3f30-4331-9716-77bf57bbe464 approved by: @arlimus

@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamescott @chef-delivery @chris-rock @arlimus