Fix gem resource on Windows #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleff
force-pushed
the
adamleff/fix-gem-on-windows
branch
from
f25a7fa
to
a2b68f0
Compare
RubyGems on windows comes with a batch file that wraps the `gem` command so it executes correctly. This change uses that batch file for windows for our `gem` resource, and also properly handles when we receive no output from the command. Signed-off-by: Adam Leff <adam@leff.co>
chris-rock
force-pushed
the
adamleff/fix-gem-on-windows
branch
from
a2b68f0
to
da56a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyGems on windows comes with a batch file that wraps the
gemcommandso it executes correctly. This change uses that batch file for windows
for our
gemresource, and also properly handles when we receive no outputfrom the command.
Fixes #1645