harmonize compliance profiles view with supermarket views #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/optimize-compliance-cli
branch
from
77e21e2
to
29f46c0
Compare
chris-rock
changed the title
chris-rock
force-pushed
the
chris-rock/optimize-compliance-cli
branch
from
29f46c0
to
efd9153
Compare
adamleff
approved these changes
Apr 13, 2017
| @@ -57,7 +57,14 @@ def login(server) # rubocop:disable Metrics/AbcSize | |||
| puts '', msg | |||
| end | |||
|
|
|||
| desc "login_automate SERVER --user='USER' --ent='ENT' --dctoken or --usertoken='TOKEN'", 'Log in to an Automate SERVER' | |||
| desc "login_automate SERVER --insecure --user='USER' --ent='ENT' --usertoken='TOKEN'", 'Log in to an Automate SERVER' | |||
There was a problem hiding this comment.
I would love to see this be inspec compliance login --automate in the future than require a completely separate command. It feels weird to me from a CLI UX perspective. Not a blocker, obviously :)
| { org: owner, name: name } | ||
| end | ||
| end.flatten | ||
| mapped_profiles = [] |
There was a problem hiding this comment.
We could use another Rubyism I love... #each_with_object:
mapped_profiles = profiles.values.each_with_object([]) do |org, memo|
memo << org.values
end
Again, not a blocker, just passing along something I always try and address when I see an empty object being created just to populate it with enumeration.
lib/bundles/inspec-compliance/cli.rb
Outdated
| @@ -260,6 +269,16 @@ def logout | |||
|
|
|||
| private | |||
|
|
|||
| # returns a parsed url for `admin/profile` or `compliance://admin/profile` | |||
| def sanitize_profile_name(profile) | |||
| if profile.is_a?(String) && URI(profile).scheme == 'compliance' | |||
There was a problem hiding this comment.
When would profile not be a String?
|
@chris-rock Can we fix the failing functional test before merge? |
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/optimize-compliance-cli
branch
from
efd9153
to
a0da23f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
inspec compliance profileslist to our supermarket viewcompliance://admin/profileandadmin/profileas input