Add command-line completions for fish shell #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
suggested changes
May 4, 2017
Since the command to enable them is different, also make that change in the output based on the shell used. Signed-off-by: Nathan L Smith <smith@chef.io>
Fixed. Do we have any plans to move from rubocop to chefstyle to make the coding style guides consistent across Ruby-based projects? I didn't catch these linting errors because my editor is set up to use chefstyle. |
|
@smith It has been discussed but is not currently planned. |
adamleff
approved these changes
May 4, 2017
chris-rock
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the command to enable them is different, also make that change in
the output based on the shell used.