Allow mysql_session to test databases on different hosts #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dumb DCO sign off :( and merge branches ... |
|
I don't think those functional test failures are because of me ... |
aaronlippold
force-pushed
the
al/mysql-session-update
branch
from
4f5e4c4
to
af75cd8
Compare
arlimus
reviewed
May 9, 2017
lib/resources/mysql_session.rb
Outdated
| describe sql.query('show databases like \'test\';') do | ||
| its('stdout') { should_not match(/test/) } | ||
| end | ||
| " | ||
|
|
||
| def initialize(user = nil, pass = nil) | ||
| def initialize(user = nil, pass = nil, host = localhost) |
There was a problem hiding this comment.
Should this be , host = 'localhost' ?
aaronlippold
force-pushed
the
al/mysql-session-update
branch
from
af75cd8
to
afae887
Compare
Signed-off-by: Aaron Lippold <lippold@gmail.com>
aaronlippold
force-pushed
the
al/mysql-session-update
branch
from
afae887
to
8bad7d8
Compare
arlimus
approved these changes
May 9, 2017
adamleff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.