Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not expose stderr method via os_env #179

Merged
merged 4 commits into from
Nov 1, 2015
Merged

do not expose stderr method via os_env #179

merged 4 commits into from
Nov 1, 2015

Conversation

chris-rock
Copy link
Contributor

No description provided.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

def stderr
@command_result.stderr
end

def exit_status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too ;)

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@chef-delivery
Copy link
Contributor

This PR has passed 'Verify' and is ready for review and approval!
Use: '@delivery approve' when code review is complete.

@arlimus
Copy link
Contributor

arlimus commented Nov 1, 2015

@delivery approve

chef-delivery added a commit that referenced this pull request Nov 1, 2015
Merged change 2a868e9f-90a3-4cc6-9c4c-ba510f43ac11

From review branch os_env into master

Signed-off-by: drichter <drichter@chef.io>
@chef-delivery chef-delivery merged commit bc15c85 into master Nov 1, 2015
@chef-delivery chef-delivery deleted the os_env branch November 1, 2015 23:15
@chef-delivery
Copy link
Contributor

Change: 2a868e9f-90a3-4cc6-9c4c-ba510f43ac11 approved by: @arlimus

@arlimus
Copy link
Contributor

arlimus commented Nov 1, 2015

Great simplification!

@chef-delivery
Copy link
Contributor

This PR has passed 'Acceptance' and is ready to be delivered!
Use: '@delivery deliver' when validated in acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants