Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

read source code if profile is in tgz/zip #1816

Merged
merged 1 commit into from
May 16, 2017
Merged

read source code if profile is in tgz/zip #1816

merged 1 commit into from
May 16, 2017

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented May 16, 2017

To note: the source location between archived files and an uncompressed profiel is still different. When the block gets processed the location for uncompressed files will have the full path on the system, while archives still only carry their mocked paths. This can be improved in a separate PR. This PR respects this distinction and only targets the empty code fields.

This issue has been bugging me since InSpec's original inception 馃榿

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement @arlimus

@chris-rock
Copy link
Contributor

Fixes #1580

@arlimus
Copy link
Contributor Author

arlimus commented May 16, 2017

Working on the windows issue, know where it is...

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@chris-rock chris-rock merged commit 8b015f5 into master May 16, 2017
@chris-rock chris-rock deleted the dr/source branch May 16, 2017 11:32
@adamleff adamleff changed the title bugfix: read source code if profile is in tgz/zip read source code if profile is in tgz/zip May 17, 2017
@adamleff adamleff added the Type: Bug Feature not working as expected label May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants