Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return version as json #1822

Merged
merged 2 commits into from
May 17, 2017
Merged

return version as json #1822

merged 2 commits into from
May 17, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented May 17, 2017 •
edited
Loading 

inspec version --format json
{"version":"1.24.0"}

@chris-rock
return version as json
1aa223c 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@adamleff
Added functional tests for inspec version --format json
0d91fef 
Signed-off-by: Adam Leff <adam@leff.co>
@adamleff adamleff self-requested a review May 17, 2017 13:42
@adamleff adamleff added the Type: Enhancement Improves an existing feature label May 17, 2017
adamleff
adamleff approved these changes May 17, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test added. LGTM! Thanks @chris-rock

@adamleff adamleff merged commit 60825a3 into master May 17, 2017
@adamleff adamleff deleted the chris-rock/version-as-json branch May 17, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-rock @adamleff