Habitat Profiles: redirect stderr to stdout #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -346,16 +352,15 @@ def run_hook_contents | |||
|
|
|||
| while true; do | |||
| echo "Executing InSpec for ${PROFILE_IDENT}" | |||
| inspec exec {{pkg.path}}/dist --format=json > ${RESULTS_FILE} 2>${ERROR_FILE} | |||
| inspec exec {{pkg.path}}/dist --format=json > ${RESULTS_FILE} | |||
There was a problem hiding this comment.
Now that we're deleting this can you also remove https://github.com/chef/inspec/pull/1826/files#diff-93d8a0fc1b64e361ffb0725d8ed10a37L342
adamleff
force-pushed
the
adamleff/no-more-stderr
branch
from
f908804
to
0940c64
Compare
chris-rock
approved these changes
May 29, 2017
Due to habitat-sh/habitat#2395, we shouldn't try to log stderr output to a file for now. While this makes for a less-than-awesome UX, it's better than a process locking up due to a buffer filling up! This change redirects stderr from InSpec to stdout and adds some helpful troubleshooting messages. Should InSpec be able to generate unique exit codes for when controls fail (vs. a Ruby eval failure) then we can fix this up some more, too. Signed-off-by: Adam Leff <adam@leff.co>
chris-rock
force-pushed
the
adamleff/no-more-stderr
branch
from
0940c64
to
266f061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to habitat-sh/habitat#2395, we shouldn't try to log stderr output
to a file for now. While this makes for a less-than-awesome UX, it's
better than a process locking up due to a buffer filling up!
This change redirects stderr from InSpec to stdout and adds some
helpful troubleshooting messages. Should InSpec be able to generate
unique exit codes for when controls fail (vs. a Ruby eval failure)
then we can fix this up some more, too.