api: change --disable-sudo to --sudo
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align with options in train. This also prevents unexpected behavior where sudo is used, without being requested. Example:
```
command('uname -a')
```
This command will not run if no sudo information is given and e.g. a sudo password is configured on the node. The user can activate sudo usage with `--sudo` now.
|
yeah, that is simpler @arlimus |
|
This PR has passed 'Verify' and is ready for review and approval! |
|
@delivery approve |
chef-delivery
added a commit
that referenced
this pull request
Nov 2, 2015
Merged change 8d2ada5d-1492-43ca-9655-93ca593cd900 From review branch sudo into master Signed-off-by: chartmann <chartmann@chef.io>
|
Change: 8d2ada5d-1492-43ca-9655-93ca593cd900 approved by: @chris-rock |
|
This PR has passed 'Acceptance' and is ready to be delivered! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the old default and use:
for configuration. By default, sudo is now disabled (as it is in train).