Fix command exists check on Windows with full paths

[username-is-already-taken2]

Amended the command.rb file as it wasn't passing the path correctly.

Needed to force the return of exit code numbers (rather than $ture $false) to maintain compatiblity with the existing script

chefconf 2017

Fixes #1839

[arlimus]

Yay thank you @username-is-already-taken2 for hacking this at ChefConf 😄

[chris-rock]

Awesome improvement @username-is-already-taken2

[arlimus]

one more verification for regressions...

[chris-rock]

While Test-Path looks great at first, the following is not turning green:

cmd = 'C:\Windows\System32\cscript.exe'
describe powershell("If(Test-Path \"#{cmd}\"){exit 0}Else{exit 1}") do
  its('exit_status') { should eq 0 }
end

cmd2 = 'cscript.exe'
describe powershell("If(Test-Path \"#{cmd2}\"){exit 0}Else{exit 1}") do
  its('exit_status') { should eq 0 }
end

We need to find a solution for all commands without absolute paths

[arlimus]

as detected by Chris :) i think a simple condition should solve this

Duplicate of Chris' review

[username-is-already-taken2]

I thought I might have to get funky with an if statement, in the end I swapped out the cmdlet

Here is what I used to validate it.

describe command('C:\Windows\System32\cscript.exe') do
  it { should exist }
  its('exit_status') { should eq 0 }
end

describe command('C:/Windows/System32/cscript.exe') do
  it { should exist }
  its('exit_status') { should eq 0 }
end

describe command('cscript.exe') do
  it { should exist }
  its('exit_status') { should eq 0 }
end

describe command('cscript2.exe') do
  it { should_not exist }
end

[username-is-already-taken2]

I have revised the cmdlet used and updated the pr

[adamleff]

Tested this locally and it works great! Thanks again, @username-is-already-taken2

[arlimus]

Tested and verified, awesome update @username-is-already-taken2 !! Kudos :)

verified it, works now