Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameters to find commands #1856

Merged
merged 2 commits into from
May 31, 2017
Merged

Fix parameters to find commands #1856

merged 2 commits into from
May 31, 2017

Conversation

chris-rock
Copy link
Contributor

@chris-rock chris-rock commented May 29, 2017 •
edited
Loading

fixes #1828

@chris-rock
Copy link
Contributor Author

This PR includes the commits from #1854 and fixes the same issue in other places, too

@chris-rock chris-rock mentioned this pull request May 29, 2017
Closed
@chris-rock chris-rock force-pushed the chris-rock/1828 branch 2 times, most recently from 48799e3 to 7011fc3 Compare May 29, 2017 20:27
aaronlippold and others added 2 commits May 31, 2017 00:20
@aaronlippold @chris-rock
small syntax fix to interface resource.
eacae80 
addresses #1828

Signed-off-by: Aaron Lippold <lippold@gmail.com>
@chris-rock
fix #1828
57097ea 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@adamleff adamleff changed the title fixes #1828 Fix parameters to find commands May 31, 2017
@adamleff adamleff added the Type: Bug Feature not working as expected label May 31, 2017
adamleff
adamleff approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chris-rock, and thanks @aaronlippold for the initial PR.

@adamleff adamleff merged commit f14ed84 into master May 31, 2017
@adamleff adamleff deleted the chris-rock/1828 branch May 31, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamleff adamleff adamleff approved these changes

@aaronlippold aaronlippold Awaiting requested review from aaronlippold

Assignees
No one assigned
Labels
Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"-type f -maxdepth 1" should be "-maxdepth 1 -type f"
3 participants
@chris-rock @adamleff @aaronlippold