Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verifies that inspec.yml uses licenses in SPDX format #1858

Merged
merged 2 commits into from
May 31, 2017
Merged

verifies that inspec.yml uses licenses in SPDX format #1858

merged 2 commits into from
May 31, 2017

Conversation

chris-rock
Copy link
Contributor

fixes #1836

@chris-rock
Copy link
Contributor Author

Special thanks to @tas50 for providing the idea for the rake task in https://github.com/Foodcritic/foodcritic/pull/530/files

@chris-rock chris-rock force-pushed the chris-rock/spdx branch 2 times, most recently from cac04d9 to 9d8e84c Compare May 30, 2017 03:43
@arlimus arlimus requested review from adamleff and arlimus May 30, 2017 04:00
arlimus
arlimus approved these changes May 30, 2017
View reviewed changes
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super sweet, thank you @chris-rock !!

@chris-rock
verifies that inspec.yml uses licenses in SPDX format
a6ef98c 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
update unit tests
687f1a5 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@adamleff adamleff added the Type: Enhancement Improves an existing feature label May 31, 2017
adamleff
adamleff approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool - thanks @chris-rock!

@adamleff adamleff merged commit e254f79 into master May 31, 2017
@adamleff adamleff deleted the chris-rock/spdx branch May 31, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlimus arlimus arlimus approved these changes

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use SPDX license identifiers
3 participants
@chris-rock @arlimus @adamleff