Commenting the contain_duplicates deprecation until we have a good alternative
#1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ood alternative. Signed-off-by: Alex Pop <apop@chef.io>
chris-rock
reviewed
May 30, 2017
lib/matchers/matchers.rb
Outdated
| @@ -88,7 +88,7 @@ | |||
|
|
|||
| RSpec::Matchers.define :contain_duplicates do | |||
| match do |arr| | |||
| warn '[DEPRECATION] `contain_duplicates` is deprecated and will be removed in the next major version. See https://github.com/chef/inspec/issues/738 for more details' | |||
| # warn '[DEPRECATION] `contain_duplicates` is deprecated and will be removed in the next major version. See https://github.com/chef/inspec/issues/738 for more details' | |||
There was a problem hiding this comment.
I think we should just remove the comment completely
There was a problem hiding this comment.
I'm going to adopt this change now and remove the line.
We can add it back in when we have a better solution and we actually want to deprecate it. Signed-off-by: Adam Leff <adam@leff.co>
adamleff
approved these changes
Jun 6, 2017
|
Thank you Adam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.