Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version method call for refresh token #1875

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Fix version method call for refresh token #1875

merged 1 commit into from
Jun 1, 2017

Conversation

ndobson
Copy link

@ndobson ndobson commented May 31, 2017

@chris-rock I think you missed one when you refactored Compliance::API.version here:

5cc288d

Fixes below error:

inspec compliance login https://compliance.something --user='someuser' --refresh-token='atoken'
/opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.26.0/lib/bundles/inspec-compliance/api.rb:64:in `version': wrong number of arguments (given 2, expected 1) (ArgumentError)
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.26.0/lib/bundles/inspec-compliance/cli.rb:358:in `store_refresh_token'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.26.0/lib/bundles/inspec-compliance/cli.rb:48:in `login'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/invocation.rb:115:in `invoke'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor.rb:235:in `block in subcommand'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
	from /opt/inspec/embedded/lib/ruby/gems/2.3.0/gems/inspec-1.26.0/bin/inspec:12:in `<top (required)>'
	from /opt/inspec/bin/inspec:59:in `load'
	from /opt/inspec/bin/inspec:59:in `<main>'

Fix version method call
7a4ff97 
Signed-off-by: Nick Dobson <nick.dobson@me.com>
@adamleff adamleff added the Type: Bug Feature not working as expected label May 31, 2017
@adamleff adamleff requested a review from chris-rock May 31, 2017 19:35
adamleff
adamleff approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ndobson - thanks for the PR!

chris-rock
chris-rock approved these changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who did this in the first place :-) Well done. Thank you @ndobson for covering!

@chris-rock chris-rock merged commit be2453d into inspec:master Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-rock chris-rock chris-rock approved these changes

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndobson @chris-rock @adamleff