Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the Nginx parser #1888

Merged
merged 1 commit into from
Jun 5, 2017
Merged

add the Nginx parser #1888

merged 1 commit into from
Jun 5, 2017

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jun 3, 2017

The resource will be handled i a separate PR.

Signed-off-by: Dominik Richter dominik.richter@gmail.com

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus added Type: Enhancement Improves an existing feature in progress labels Jun 3, 2017
@aaronlippold
Copy link
Collaborator

👍 looking forward to the next PR :)

Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd rather see the tests show real examples of pulling values out of the parsed configuration rather than the exact representation of the parselet output (i.e. :section=>{:identifier=>\"group\"@0}) as it feels like we're testing parselet more than our ability to use parselet to get values out of a configuration.

Otherwise approved though :)

@arlimus
Copy link
Contributor Author

arlimus commented Jun 5, 2017

@adamleff Since I'm testing both the lexer and the transformer and both can have errors I prefer these tests to quickly tell me where problems are. I fully agree that they aren't as nice, especially with the positional arguments, but it was the only way I found so far to get the interface between those components tested.

The last layer will come through the nginx config itself, which are the testable end restults i.e. the nginx to params mapping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants