Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate message in describe.one blocks #1896

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jun 6, 2017

Generated duplicate messages due to the way that examples are aggregated in RSpec. Make sure we never show any duplicate test result messages, as they offer not value to any user.

Signed-off-by: Dominik Richter dominik.richter@gmail.com

@arlimus arlimus added the Type: Bug Feature not working as expected label Jun 6, 2017
@arlimus arlimus requested a review from adamleff June 6, 2017 20:39
@arlimus
Copy link
Contributor Author

arlimus commented Jun 6, 2017

Solves internal issue: https://chefio.atlassian.net/browse/CMP-177

Generated duplicate messages due to the way that examples are aggregated in RSpec. Make sure we never show any duplicate test result messages, as they offer not value to any user.

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@adamleff adamleff changed the title bugfix: remove duplicate message in describe.one blocks remove duplicate message in describe.one blocks Jun 7, 2017
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix for an annoying problem. :) Thanks, @arlimus!

@adamleff adamleff merged commit 0d61401 into master Jun 7, 2017
@adamleff adamleff deleted the dr/dupe-message branch June 7, 2017 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants