inspec archive for tgz files on windows #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to #1906 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
arlimus
force-pushed
the
dr/windows-tgz-bug
branch
from
547670e
to
d36acf1
Compare
chris-rock
approved these changes
Jun 8, 2017
adamleff
changed the title
aaronlippold
pushed a commit
to aaronlippold/inspec
that referenced
this pull request
Jun 8, 2017
On Windows, `inspec archive` would sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one: ``` Unable to parse inspec.yml: line 1, control characters are not allowed ``` Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway. Closely related to inspec#1906 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows,
inspec archivewould sometimes produce incorrect archive files. These would look fine, as tgz files, but would not execute correctly. This would lead to bewildering error messages like this one:Fix it by treating the files as binary before writing them to get around any encoding issues, since the stream handler is a raw io object anyway.
Closely related to #1906