Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TCP reachability support on Linux for host resource #1915

Merged
merged 3 commits into from
Jun 9, 2017

Conversation

adamleff
Copy link
Contributor

@adamleff adamleff commented Jun 9, 2017

This enhances the host resource on Linux targets by using netcat
(if installed) to perform TCP reachability checks.

This enhances the `host` resource on Linux targets by using netcat
(if installed) to perform TCP reachability checks.

Signed-off-by: Adam Leff <adam@leff.co>
warn '[DEPRECATION] The `proto` parameter is deprecated. Use `protocol` instead.'
@protocol = params[:proto]
else
@protocol = params.fetch(:protocol, 'icmp')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great deprecation!

Signed-off-by: Adam Leff <adam@leff.co>
Signed-off-by: Adam Leff <adam@leff.co>
Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great direction and improvement over the previous iteration.
Thank you Adam!!

@arlimus arlimus merged commit 12a495c into master Jun 9, 2017
@arlimus arlimus deleted the adamleff/add-tcp-to-host-resource branch June 9, 2017 16:20
@adamleff adamleff added the Type: New Feature Adds new functionality label Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Adds new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants