Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix intermitten functional vendor test failures #1919

Merged
merged 2 commits into from
Jun 12, 2017

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jun 12, 2017

... it's been bugging us for a while, intermittenfailures in test suite #3 on travis because of these vendor tests. Try to resolve it by fully embracing parallelism (everything must be able to work properly at perallel execution!).

Signed-off-by: Dominik Richter dominik.richter@gmail.com

@arlimus arlimus added Type: Bug Feature not working as expected in progress labels Jun 12, 2017
@arlimus arlimus force-pushed the dr/functional-intermitten-failures branch 4 times, most recently from 1746761 to 9556d22 Compare June 12, 2017 10:13
@arlimus
Copy link
Contributor Author

arlimus commented Jun 12, 2017

Fun story, the test that is failing was completely disfunctional before. It points to a real issue under the hood. Good to get this cleaned up :)

@arlimus arlimus force-pushed the dr/functional-intermitten-failures branch 2 times, most recently from 458bfbf to a15f662 Compare June 12, 2017 10:41
@arlimus
Copy link
Contributor Author

arlimus commented Jun 12, 2017

Depends on #1920 to get green.

@arlimus
Copy link
Contributor Author

arlimus commented Jun 12, 2017

I also noticed that there may be some intermitten failures in one of the other functional tests too (I think artifact?), i.e. it may require another PR to fully take care of them. The way I approached this PR was to gather functional tests over the course of the last week and saved them all. Something similar should imho be done in the form of an issue if we see more intermitten failures pop up.

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus force-pushed the dr/functional-intermitten-failures branch from a15f662 to 840553f Compare June 12, 2017 11:02
@arlimus arlimus changed the title WIP fix intermitten functional vendor test failures fix intermitten functional vendor test failures Jun 12, 2017
@arlimus
Copy link
Contributor Author

arlimus commented Jun 12, 2017

Hah speak of the devil:

  1) Error:
inspec exec#test_0002_can sign, verify and install a signed profile:
Errno::ENOENT: No such file or directory @ dir_initialize - 93e4b1aa-dbd2-4c80-bfa0-2449cce60da5
    /home/travis/build/chef/inspec/test/functional/inspec_artifact_test.rb:40:in `open'
    /home/travis/build/chef/inspec/test/functional/inspec_artifact_test.rb:40:in `entries'
    /home/travis/build/chef/inspec/test/functional/inspec_artifact_test.rb:40:in `block (2 levels) in <top (required)>'

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
@arlimus arlimus force-pushed the dr/functional-intermitten-failures branch from 29c2e38 to 0b866f4 Compare June 12, 2017 11:23
@arlimus
Copy link
Contributor Author

arlimus commented Jun 12, 2017

Fixed the artifcat tests too

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. Thank you for chasing this one down @arlimus

@chris-rock chris-rock merged commit 54444e8 into master Jun 12, 2017
@chris-rock chris-rock deleted the dr/functional-intermitten-failures branch June 12, 2017 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants