-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix intermitten functional vendor test failures #1919
Conversation
1746761
to
9556d22
Compare
Fun story, the test that is failing was completely disfunctional before. It points to a real issue under the hood. Good to get this cleaned up :) |
458bfbf
to
a15f662
Compare
Depends on #1920 to get green. |
I also noticed that there may be some intermitten failures in one of the other functional tests too (I think artifact?), i.e. it may require another PR to fully take care of them. The way I approached this PR was to gather functional tests over the course of the last week and saved them all. Something similar should imho be done in the form of an issue if we see more intermitten failures pop up. |
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
a15f662
to
840553f
Compare
Hah speak of the devil:
|
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
29c2e38
to
0b866f4
Compare
Fixed the artifcat tests too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement. Thank you for chasing this one down @arlimus
... it's been bugging us for a while, intermittenfailures in test suite #3 on travis because of these vendor tests. Try to resolve it by fully embracing parallelism (everything must be able to work properly at perallel execution!).
Signed-off-by: Dominik Richter dominik.richter@gmail.com