Adding toml resource #1924
Merged
Adding toml resource #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `toml` resource that inherits from the json resource and behaves the same way as the JSON and YAML resources. Signed-off-by: Nolan Davidson <ndavidson@chef.io>
chris-rock
reviewed
Jun 15, 2017
There was a problem hiding this comment.
Great addition @nsdavidson Lets just remove the additional comments and we are good to go :-)
lib/resources/toml.rb
Outdated
|
|
||
| # Parses a TOML document | ||
| # Usage | ||
| # describe toml('default.toml') do |
There was a problem hiding this comment.
We do not need the comments, since the example is inline as part of the example
Signed-off-by: Nolan Davidson <ndavidson@chef.io>
|
@chris-rock Thanks! Comments removed. |
adamleff
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
tomlresource that inherits from the json resource andbehaves the same way as the JSON and YAML resources.
Signed-off-by: Nolan Davidson ndavidson@chef.io