Fix directory resource output and exists check #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `to_s` method on the `directory` resource is not defined in the correct class, leading `directory` resources to be printed as the parent resource (`file`) instead. Signed-off-by: Adam Leff <adam@leff.co>
Signed-off-by: Adam Leff <adam@leff.co>
adamleff
force-pushed
the
adamleff/fix-directory-output
branch
from
b5e0124
to
271d2ef
Compare
adamleff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
to_smethod on thedirectoryresource is not defined in the correct class, leadingdirectoryresources to be printed as the parent resource (file) instead.Also, the
exist?method just reuses thefileresource'sexist?method which can lead to perceived false results when a user callsit {should exist}on a file with thedirectorymethod thinking it's actually checking to see if the target is a directory as well. This change ensures that theexist?method also checks to make sure the target is a directory.Fixes #1944