make postgres resource working in mock runner (for inspec check) #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/postgres
branch
from
6873e66
to
34b691c
Compare
adamleff
previously requested changes
Jun 23, 2017
lib/resources/postgres.rb
Outdated
| @@ -11,6 +11,9 @@ class Postgres < Inspec.resource(1) | |||
|
|
|||
| attr_reader :service, :data_dir, :conf_dir, :conf_path, :version, :cluster | |||
| def initialize | |||
| @conf_dir = '' | |||
There was a problem hiding this comment.
Why empty strings and not nil?
There was a problem hiding this comment.
Agree on that one :-)
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/postgres
branch
from
34b691c
to
89c25ed
Compare
arlimus
force-pushed
the
chris-rock/postgres
branch
from
89c25ed
to
9dc3829
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
arlimus
force-pushed
the
chris-rock/postgres
branch
from
9dc3829
to
6398660
Compare
arlimus
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to use the postgres resources in mock environments with empty data better. Also, this is required to get inspec check for https://github.com/dev-sec/postgres-baseline green again