Fix formatter when two profiles have the same name #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that an InSpec runner has two profiles that are named the same (such as when InSpec generates a profile for the Flat source reader, and Test Kitchen is running concurrently), InSpec could hand back a profile that does not contain the example. This leads to nil control data and ugly NilClass errors when TK runs concurrently. This change modifies the method that finds the profile by control to not only match on profile name but also match on example ID. Signed-off-by: Adam Leff <adam@leff.co>
Signed-off-by: Adam Leff <adam@leff.co>
chris-rock
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that an InSpec runner has two profiles that are named the same (such as when InSpec generates a profile for the Flat source reader, and Test Kitchen is running concurrently), InSpec could hand back a profile that does not contain the example. This leads to nil control data and ugly NilClass errors when TK runs concurrently.
This change modifies the method that finds the profile by control to not only match on profile name but also match on example ID.
Fixes #1598