New 'be_in' matcher for matching against values in a list #2022
Conversation
Fixes inspec#2018 Signed-off-by: Rony Xavier <rx294@nyu.edu>
Signed-off-by: Aaron Lippold <lippold@gmail.com>
aaronlippold
force-pushed
the
al/new_matcher_be_in
branch
from
ad9e618
to
c48a038
Compare
describe nginx do
its(module_list) { should be_in AUTHORIZED_MODULE_LIST }
end
Fixes inspec#2018
Signed-off-by: Rony Xavier <rx294@nyu.edu>
Fixes inspec#2018 Signed-off-by: Rony Xavier <rx294@nyu.edu>
There was a problem hiding this comment.
This is a great addition @rx294 Lets just add integration tests!
| @@ -78,6 +78,40 @@ | |||
| end | |||
|
|
|||
| it 'constructs a simple resource+argument with method calls' do | |||
| obj.qualifier = [['resource'], ['hello', 'world']] | |||
There was a problem hiding this comment.
Those tests are great, but they are not testing the be_in matcher. Instead they only verify that the inspec obects code generates the right InSpec ruby code. Instead I propose to create a new test/integration/matcher_test.rb. This will run RSpec and test the matcher. See https://github.com/chef/inspec/blob/master/test/integration/default/cmp_matcher_spec.rb
There was a problem hiding this comment.
Thank you @chris-rock, I misunderstood. I will add the tests.
There was a problem hiding this comment.
@chris-rock I have pushed up test/integration/matcher_test.rb for the 'be_in' matcher with tests that mirror the cmp matcher tests.
Please take a look.
Thank you
Signed-off-by: Rony Xavier <rx294@nyu.edu>
rx294
force-pushed
the
al/new_matcher_be_in
branch
from
b6ec7e5
to
40de30a
Compare
lib/matchers/matchers.rb
Outdated
| RSpec::Matchers.define :be_in do |list| | ||
| match do |item| | ||
| # Handle both single item and array | ||
| item.is_a?(Array) ? (item-list).empty? : list.include?(item) |
There was a problem hiding this comment.
Normal Ruby styling includes a space around operators. Can you please make this (item - list) so it's clearer?
lib/matchers/matchers.rb
Outdated
|
|
||
| match_when_negated do |item| | ||
| # Handle both single item and array | ||
| item.is_a?(Array) ? (item&list).empty? : !list.include?(item) |
There was a problem hiding this comment.
Normal Ruby styling includes a space around operators. Can you please make this (item & list) so it's clearer?
lib/matchers/matchers.rb
Outdated
|
|
||
| failure_message_when_negated do |item| | ||
| if item.is_a?(Array) | ||
| "expected `#{item}` not to be in the list: `#{list}` \nComm:\n #{(item&list)}" |
There was a problem hiding this comment.
Normal Ruby styling includes a space around operators. Can you please make this (item & list) so it's clearer?
There was a problem hiding this comment.
Thank you @adamleff I have made the corrects.
Signed-off-by: Rony Xavier <rx294@nyu.edu>
rx294
force-pushed
the
al/new_matcher_be_in
branch
from
29e4bac
to
9b68747
Compare
adamleff
changed the title
|
|
||
| INSTALLED_MODULES = ['module1', 'module2', 'module3', 'module4', 'module5'] | ||
|
|
||
| describe 'module1' do |
There was a problem hiding this comment.
That is awesome! Thank you @rx294
Fixes #2018
Signed-off-by: Rony Xavier rx294@nyu.edu