Fix issue when xinetd.conf does not end in newline #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trickyearlobe
requested review from
arlimus and
adamleff
and removed request for
arlimus and
adamleff
Add a newline symbol to the end of the parsed input. Sample hexdump of a file deployed by xinetd cookbook: $ hexdump -C /var/chef/cache/cookbooks/xinetd/templates/default/xinetd.conf.erb | tail -2 000000b0 72 20 2f 65 74 63 2f 78 69 6e 65 74 64 2e 64 |r /etc/xinetd.d| 000000bf Signed-off-by: Simonas Kareiva <simonas@5grupe.lt>
chris-rock
approved these changes
Aug 2, 2017
arlimus
added a commit
that referenced
this pull request
Aug 2, 2017
The fix is already provided here: #2040 This PR only adds a unit test to catch it
arlimus
added a commit
that referenced
this pull request
Aug 2, 2017
The fix is already provided here: #2040 This PR only adds a unit test to catch it Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
chris-rock
pushed a commit
that referenced
this pull request
Aug 2, 2017
The fix is already provided here: #2040 This PR only adds a unit test to catch it Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a newline symbol to the end of the parsed input.
Sample hexdump of xinetd.conf when deployed by the xinetd cookbook: