Assume sqlplus as oracle_session as default for mock environments #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
commented
Aug 11, 2017
lib/resources/oracledb_session.rb
Outdated
| bin = @sqlcl_bin | ||
| opts = "set sqlformat csv\nSET FEEDBACK OFF" | ||
| p = :parse_csv_result | ||
| else inspec.command(@sqlplus_bin).exist? |
There was a problem hiding this comment.
Thank you @adamleff I am going to fix this
chris-rock
force-pushed
the
chris-rock/ora-mock
branch
from
712f59e
to
e27a702
Compare
|
This PR requires inspec/train#187 to be merged before it will turn into green |
…e will catch this missing cli but it prevents inspec check from failing if sqlplus is not available Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/ora-mock
branch
from
e27a702
to
c0d4793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cases where inspec check was executed but failed because the mock environment is not checking for real binaries