Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing command mocks to fix tests after train 0.26.1 upgrade #2069

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

adamleff
Copy link
Contributor

Train 0.26.1 fixes a bug where missing mocked commands would return a zero exit code. This resulted in some unit tests failing due to missing mocked commands.

Train 0.26.1 fixes a bug where missing mocked commands would return
a zero exit code. This resulted in some unit tests failing due to
missing mocked commands.

Signed-off-by: Adam Leff <adam@leff.co>
@adamleff adamleff requested a review from a team August 14, 2017 17:00
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adamleff

@chris-rock chris-rock merged commit c467ca3 into master Aug 14, 2017
@chris-rock chris-rock deleted the adamleff/fix-tests-from-train branch August 14, 2017 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants