Properly handle held packages on dpkg-flavored OS #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu Sauve-Frankel <msf@kisoku.net>
InSpec was looking at the wrong field in `dpkg -s` output to determine whether a package was installed or not. An installed, held package was incorrectly reported as uninstalled. This adds the proper unit tests and also adds a `be_held` matcher. Thanks to @kisoku for the initial work in #2007. Signed-off-by: Adam Leff <adam@leff.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InSpec was looking at the wrong field in
dpkg -soutput to determine whether a package was installed or not. An installed, held package was incorrectly reported as uninstalled.A
be_heldmatcher has been added as well.Fixes #2006