Add version to resource declaration #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is necessary, and looking through the git history it seems like it's been necessary for some time.
|
Good catch, thank you @jcreedcmu ! 👍 There was a plan at an early stage to just leave it off and run with v1 if it's nil, but that was never put into practice. A good decision, as this is better practice. |
arlimus
added a commit
that referenced
this pull request
Nov 5, 2015
Add version to resource declaration
clintoncwolfe
pushed a commit
that referenced
this pull request
Feb 7, 2018
Signed-off-by: Miah Johnson <miah@chia-pet.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is necessary, and looking through the git history it seems like it's been necessary for some time.