Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: rewrite registry_key resource, serverspec compatibility and add integration tests #233

Merged
merged 9 commits into from
Nov 17, 2015
Merged

improvement: rewrite registry_key resource, serverspec compatibility and add integration tests #233

merged 9 commits into from
Nov 17, 2015

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Nov 12, 2015

No description provided.

@arlimus arlimus mentioned this pull request Nov 12, 2015
Merged
@chris-rock chris-rock force-pushed the alexpop/registry_key branch 2 times, most recently from 62f69e4 to 6eef0b6 Compare November 17, 2015 13:19
@chris-rock chris-rock changed the title add registry_key recipe and spec tests rewrite registry_key resource and add integration tests Nov 17, 2015
@chris-rock
Copy link
Contributor

This PR includes the following updates:

  • complete rewrite of registry_key resource
  • optimized data retrieval
  • compatibility with Serverspec
  • integration tests with Windows 2012 and Windows 2012 R2

@chris-rock chris-rock changed the title rewrite registry_key resource and add integration tests improvement: rewrite registry_key resource, serverspec compatibility and add integration tests Nov 17, 2015
@arlimus
Copy link
Contributor

arlimus commented Nov 17, 2015

This is a huge improvement to registry-keys, thank you both so much!! 💯

arlimus added a commit that referenced this pull request Nov 17, 2015
@arlimus
Merge pull request #233 from chef/alexpop/registry_key
254f672 
improvement: rewrite registry_key resource, serverspec compatibility and add integration tests
@arlimus arlimus merged commit 254f672 into master Nov 17, 2015
@arlimus arlimus deleted the alexpop/registry_key branch November 17, 2015 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexpop @chris-rock @arlimus