Unique export file for security policy resource #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
commented
Nov 29, 2017
lib/resources/security_policy.rb
Outdated
| return skip_resource "Can't read security policy" if cmd.exit_status.to_i != 0 | ||
| @content = cmd.stdout | ||
|
|
||
| if @content.empty? && !file.empty? |
There was a problem hiding this comment.
This was removed as it seems to be legacy code. We don't have any local file variable. In the future we could look into using the Train::File to capture the content of the policy.
There was a problem hiding this comment.
I think we should remove the content check completely. If the content is empty, we should not expect that to be okay, so it is probably a failure. Can we add a test that ensures the parsing is not crashing if we have an empty file?
adamleff
approved these changes
Nov 29, 2017
Signed-off-by: Jared Quick <jquick@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SecurityPolicy resource has a potential race condition when exporting the policy. If two runners were both working on the SecurityPolicy resource one could delete the policy export file before the other finished the export. This would cause the policy test to fail on the second runner.
This change is to create a SecureRandom hex and append it to the policy export file. This resolves the issue as each instance will have its own unique file.
Signed-off-by: Jared Quick jquick@chef.io