Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspec appveyor test with the new local train transport #2376

Merged
merged 2 commits into from Dec 6, 2017

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Dec 6, 2017

The new Train local transport tries to use the new pipe runner here:
https://github.com/chef/inspec/blob/master/test/helper.rb#L84

This change forces it to use the generic runner which ensures we don't create pipes for every test. This PR requires inspec/train#225
Signed-off-by: Jared Quick jquick@chef.io

@jquick jquick requested a review from a team as a code owner December 6, 2017 15:11
@jquick jquick force-pushed the jq/test-appveyor branch 3 times, most recently from 986e7db to 73089cf Compare December 6, 2017 19:16
@jquick jquick changed the title DO NOT MERGE - test appveyor with ruby#File Fix inspec appveyor test with the new local train transport Dec 6, 2017
Signed-off-by: Jared Quick <jquick@chef.io>
@arlimus
Copy link
Contributor

arlimus commented Dec 6, 2017

Great to see it working :D

Signed-off-by: Jared Quick <jquick@chef.io>
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@adamleff adamleff merged commit 31578de into master Dec 6, 2017
@adamleff adamleff deleted the jq/test-appveyor branch December 6, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants