package resource: fix NilClass errors on arch linux #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies `.info` to return `{}` in cases where the package manager
cannot be determined. This matches the behavior of `@pkgman.info`.
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
adamleff
suggested changes
Jan 5, 2018
test/unit/resources/package_test.rb
Outdated
| @@ -139,6 +139,7 @@ | |||
| # undefined | |||
| it 'verify package handling on unsupported os' do | |||
| resource = MockLoader.new(:undefined).load_resource('package', 'curl') | |||
| _(resource.info).must_be_empty | |||
There was a problem hiding this comment.
The only downside with using must_be_empty here is that if resource.info ever had a regression introduced that returned an empty string, this would still pass.
It might be safer to say .must_equal({})
There was a problem hiding this comment.
Great catch! I have updated it to match what you suggested.
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
adamleff
approved these changes
Jan 8, 2018
adamleff
changed the title
nil:NilClass error for package resource
chris-rock
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
.infoto return{}in cases where the package manager cannot be determined. This matches the behavior of@pkgman.info.