Add warning when returning DEFAULT_ATTRIBUTE #2934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevorBramble
force-pushed
the
warn-on-default-attr
branch
from
0bdbec5
to
c3f0235
Compare
When the anonymous DEFAULT_ATTRIBUTE class is used, log a warning. We now pass in the attribute name to that class so it can be used in the log message. Signed-off-by: Trevor Bramble <tbramble@chef.io>
TrevorBramble
force-pushed
the
warn-on-default-attr
branch
from
c3f0235
to
a0b9ad9
Compare
jquick
approved these changes
Apr 11, 2018
jerryaldrichiii
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the anonymous DEFAULT_ATTRIBUTE class is used, log a warning.
We now pass in the attribute name to that class so it can be used in the log message.
Fixes #2865
Complement of #2891